Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tests): Added an integration test suite #664

Merged
merged 7 commits into from
Oct 10, 2024
Merged

refactor(tests): Added an integration test suite #664

merged 7 commits into from
Oct 10, 2024

Conversation

instamenta
Copy link
Contributor

Description

Added an integration test suite inside the e2e folder to separate the logic, and to run tests separately.

Related Issues

@instamenta instamenta self-assigned this Oct 9, 2024
@instamenta instamenta requested review from a team and leninmehedy as code owners October 9, 2024 12:46
@instamenta instamenta linked an issue Oct 9, 2024 that may be closed by this pull request
Add an integration test suite #360
Closed
6 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024 •
edited
Loading

Unit Test Results - Linux

  1 files  ±0   45 suites  ±0   6s ⏱️ -1s
130 tests ±0  130 ✅ ±0  0 💤 ±0  0 ❌ ±0 
142 runs  ±0  142 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit eb35ef7. ± Comparison against base commit 65a1b53.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024 •
edited
Loading

Unit Test Results - Windows

  1 files  ±0   45 suites  ±0   21s ⏱️ -1s
130 tests ±0  130 ✅ ±0  0 💤 ±0  0 ❌ ±0 
142 runs  ±0  142 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit eb35ef7. ± Comparison against base commit 65a1b53.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited
Loading

E2E Test Report

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit eb35ef7. ± Comparison against base commit 65a1b53.

♻️ This comment has been updated with latest results.

@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.60%. Comparing base (65a1b53) to head (eb35ef7).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #664      +/-   ##
==========================================
- Coverage   69.15%   66.60%   -2.55%     
==========================================
  Files          40       40              
  Lines       14560    14560              
  Branches      779      705      -74     
==========================================
- Hits        10069     9698     -371     
- Misses       4444     4794     +350     
- Partials       47       68      +21

see 20 files with indirect coverage changes

Impacted file tree graph

@codacy-production Codacy Production
Copy link

codacy-production bot commented Oct 10, 2024 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
❌ -2.30% (target: -1.00%) ✅ ∅
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (65a1b53) 14535 10186 70.08%
Head commit (eb35ef7) 14560 (+25) 9868 (-318) 67.77% (-2.30%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#664) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jeromy-cannon jeromy-cannon changed the base branch from main to 00631-switch-from-jest-to-mocha-to-enable-mocks October 10, 2024 09:48
jeromy-cannon
jeromy-cannon previously approved these changes Oct 10, 2024
View reviewed changes
@jeromy-cannon
Copy link
Contributor

Looks good, I changed the merge to branch to be 00631-switch-from-jest-to-mocha-to-enable-mocks, it should automatically update to main after #653 merges

Base automatically changed from 00631-switch-from-jest-to-mocha-to-enable-mocks to main October 10, 2024 17:36
@jeromy-cannon jeromy-cannon dismissed their stale review October 10, 2024 17:36

The base branch was changed.

@jeromy-cannon jeromy-cannon force-pushed the 00360-add-an-integration-test-suite branch from 932f047 to 65a1b53 Compare October 10, 2024 17:38
@jeromy-cannon jeromy-cannon reopened this Oct 10, 2024
@instamenta instamenta force-pushed the 00360-add-an-integration-test-suite branch from 57841e2 to 028a235 Compare October 10, 2024 17:44
@jeromy-cannon jeromy-cannon force-pushed the 00360-add-an-integration-test-suite branch from 028a235 to 6ad0069 Compare October 10, 2024 17:48
@jeromy-cannon
updated from merge
eb35ef7 
Signed-off-by: Jeromy Cannon <[email protected]>
@jeromy-cannon jeromy-cannon merged commit b9ae362 into main Oct 10, 2024
36 of 38 checks passed
@jeromy-cannon jeromy-cannon deleted the 00360-add-an-integration-test-suite branch October 10, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromy-cannon jeromy-cannon jeromy-cannon approved these changes

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy is a code owner

Assignees

@instamenta instamenta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an integration test suite
2 participants
@instamenta @jeromy-cannon